Minor comment and path changes. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be better if you lowercase APP to app |
|
I disagree. Web visible code paths have APP in capitals. e.g (from the pages I've changed) The change to lib/Cake/console/Command/ConsoleShell.php is in a code comment, thus why it's lowercase and the others are not. If you think they should all be lowercase, then maybe. But that would be a far larger change. However, APP is, IMO, better, as it means 'wherever your app is', not 'the app directory in your Cake Root' which may (if you've separated the 2, as I have) be different. |
markstory
added a commit
that referenced
this pull request
Jul 2, 2011
Minor comment and path changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are really minor, but I spotted them in passing and thought I'd deal with them.
The home.ctp line has recently been changed to that. Most web-visible lines have the APP prefix, so IMO this one should as well.